Fix: #[trace] async fn a(mut b) #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close issue tikv#112. Per the comment of @andylokandy this appears to be a residual carried over from the async-trait crate code. Signed-off-by: Mark Van de Vyver <[email protected]>
|
I suspect L259-L276 can all be removed. |
Pull Request Test Coverage Report for Build 2010728323
💛 - Coveralls |
Possibly, I'll need to understand the test cases a bit better before feeling comfortable making that kind of change. Update: So that this PR is not blocked from landing, I've added issue #121 to track this suggestion/observation |
This was referenced Mar 21, 2022
|
This is closed in PR #127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close issue #112.
Per the comment of @andylokandy this appears to be a residual
carried over from the async-trait crate code.
Signed-off-by: Mark Van de Vyver [email protected]