Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Legacy procedural macro integration tests #123

Closed
wants to merge 37 commits into from
Closed

Add: Legacy procedural macro integration tests #123

wants to merge 37 commits into from

Conversation

taqtiqa-mark
Copy link
Contributor

Address issue #81.

These tests reflect the current state of play.

They ensure migrating to the pipeline set out in issue #113,
does not break existing functionality.

Signed-off-by: Mark Van de Vyver [email protected]

@taqtiqa-mark
Doc: Describe pipeline and test execution
72f78ba 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Cargo configuration for UI test suite
999c9b1 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Legacy UI test parameter inputs - case 1
6155c9b 
This test reflects the current state of play.

Migrating to the pipeline set out in issue tikv#113 will enable this
to be replaced by the more informative text and error location:

error: this attribute takes one argument

         = help: use

 --> tests/ui/has-arguments.rs:3:1
  |
3 | #[trace(a, b)]
  | ^^^^^^^^^^^^^^^^^^^^
  |
  = note: this error originates in the attribute macro
    (in Nightly builds, run with -Z macro-backtrace for more info)

Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Legacy UI test parameter inputs - case 2
9426936 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Legacy UI test parameter inputs - case 3
ace23b2 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Legacy UI test parameter inputs - case 4
1f80f27 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Evolve: Legacy UI test parameter inputs
f12d82d 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Fix: Legacy UI test parameter input result
56020e6 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Legacy UI test parameter inputs - case 5
d04cfd0 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Legacy UI test parameter inputs - case 6
11c0b78 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Legacy UI test parameter inputs - case 7
1b2b844 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Legacy UI test parameter inputs - case 8
e195264 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Trace macro tests
bb48292 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Legacy UI test parameter inputs - case 9
a6d28a9 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Legacy UI test parameter inputs - case 10
b484d29 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Legacy UI test parameter inputs - case 11
847eba5 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Legacy UI test parameter inputs - case 12
8cb00ce 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Legacy procedural macro integration tests
b130ba9 
Address issue tikv#81.

These tests reflect the current state of play.

They ensure migrating to the pipeline set out in issue tikv#113,
does not break existing functionality.

Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Evolve: black-box false tests
626355b 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Evolve: Remove Cargo patch stanza
c069d87 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Documentation test as integration test (sync)
48117d1 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Evolve: Documentation as integration test (sync)
dfe2a36 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Documentation as integration test (async)
fb6714e 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Evolve: Documentation as integration test (sync)
69d06a3 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Evolve: Documentation as integration test (async)
432865a 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Evolve: Black-box false integration test (sync)
14a5f49 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Evolve: Black-box false integration test (async)
97ce3d6 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: License detail
f9d914b 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Example as integration test (sync)
c67f0c7 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Add: Example as integration test (async)
9c94359 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark taqtiqa-mark mentioned this pull request Mar 22, 2022
Closed
@taqtiqa-mark
Add: BE integration tests - scope & order
e42e1d1 
Signed-off-by: Mark Van de Vyver <[email protected]>
(cherry picked from commit 79e31c3)
@taqtiqa-mark
Add: Black-box false integration tests - scope & order
ffa1d93 
Signed-off-by: Mark Van de Vyver <[email protected]>
(cherry picked from commit 3278339)
@taqtiqa-mark
Add: Default name integration tests - scope & order
7d47a0d 
Signed-off-by: Mark Van de Vyver <[email protected]>
(cherry picked from commit c66c8c7)
@taqtiqa-mark
Add: Legacy UI test parameter inputs - case 1
5374eba 
This test reflects the current state of play.

Migrating to the pipeline set out in issue tikv#113 will enable this
to be replaced by the more informative text and error location:

error: this attribute takes one argument

         = help: use

 --> tests/ui/has-arguments.rs:3:1
  |
3 | #[trace(a, b)]
  | ^^^^^^^^^^^^^^^^^^^^
  |
  = note: this error originates in the attribute macro
    (in Nightly builds, run with -Z macro-backtrace for more info)

Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Evolve: Legacy UI test parameter inputs
1f81832 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Evolve: Rebase on upstream master
6357e4b 
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark
Merge branch 'master' into issue-122
dbeb576
@taqtiqa-mark
Copy link
Contributor Author

While I believe these tests could happily land, once the CI configuration issue is resolved, there are a few of reasons to close this PR:

  1. The CI configuration hasn't been resolved, as best I can tell, so there could be some gotcha lurking, and current-self and past-self are becoming estranged by the day :)
  2. These test cases seem destined to eventually migrate to the minitrace-tests crate.
  3. In intervening time, the benefit of these tests are for upstream, with the intervene time costs (see 1.) are for me.

For those reasons... closing.

Happy for this to be re-opened and merged if you want to, but I won't have bandwidth to help with any issues arising from 1. or from PR #127.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taqtiqa-mark