Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support global batch reportor #152

Merged
merged 1 commit into from
Jul 15, 2023
Merged

feat: support global batch reportor #152

merged 1 commit into from
Jul 15, 2023

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Jul 15, 2023 •
edited
Loading

  • Add a named Future, called Collected, as the return type for
    minitrace::Collector::collect(). This was previously an anonymous type generated by the async fn.

  • Replace minitrace-jaeger and minitrace-datadog's encode() function with convert(),
    which converts SpanRecord to the corresponding format's span representation.

@andylokandy andylokandy requested a review from zhongzc July 15, 2023 06:31
@zhongzc zhongzc merged commit 5f90017 into tikv:master Jul 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongzc zhongzc zhongzc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andylokandy @zhongzc