Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace println calls with log calls #196

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

0xd34d10cc
Copy link
Contributor

This will allow users to format & redirect these messages via commonly used log libraries. minitrace-jaeger and minitrace-opentelemetry already had log dependency, so this was intended, but never actually implemented?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7731204918

  • -1 of 3 (66.67%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.458%

Changes Missing Coverage Covered Lines Changed/Added Lines %
minitrace-jaeger/src/lib.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 7664443160: 0.0%
Covered Lines: 1702
Relevant Lines: 2142

💛 - Coveralls

@andylokandy andylokandy merged commit 7297b72 into tikv:master Feb 1, 2024
8 of 9 checks passed
@andylokandy
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants