Fix bloom filter compatibility issue caused by naming #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Zhang <[email protected]>
Connor1996
reviewed
Jul 17, 2024
| if (key.starts_with(prefix)) { | ||
| key.remove_suffix(prefix.size()); | ||
| Slice filter_policy_name_slice = Slice(rep_->filter_policy->Name()); | ||
| if (key.starts_with("rocksdb.BuiltinBloomFilter") || |
Signed-off-by: Yang Zhang <[email protected]> Signed-off-by: v01dstar <[email protected]>
overvenus
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tikv/tikv#17272
This is a temp fix for 6.29. Will propose a different fix for 8.10.
Since TiKV only uses RocksDB builtin bloom filters, this should be able to fix the issue.
Also planning to revert the PR that introduced this bug in rust-rocksdb, i.e. remove the suffix like ".FullBloom", "BlockBloom" and "Ribbon". After all, "BlockBloom" has been deprecated in RocksDB newer versions anyway.