Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use one mask canvas for applying #156

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

KatherineWinter
Copy link
Contributor

Use one mask to apply background color and transparent areas. Downside,
gradients cannot be used as background color.

Use one mask to apply background color and transparent areas. Downside,
gradients cannot be used as background color.
@timdream
Copy link
Owner

We will need to move createMaskCanvas.js somewhere outside of src since it is part of the demo, not the library. Perhaps assets? Please also move index.js to that directory too.

I didn't look into the function too much, but thanks for the contribution!

@KatherineWinter
Copy link
Contributor Author

KatherineWinter commented Dec 18, 2020

Bu

We will need to move createMaskCanvas.js somewhere outside of src since it is part of the demo, not the library. Perhaps assets? Please also move index.js to that directory too.

I didn't look into the function too much, but thanks for the contribution!

I would like to make it part of the library, I'll move stuff around

@timdream
Copy link
Owner

timdream commented Dec 19, 2020

I would like to make it part of the library, I'll move stuff around

I would like to keep the demo and the library separate :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants