workaround for headers mismatch in linux-libc-dev #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The headers in linux-libc-dev are different in powerpc/ppc64el compared to other archs, they seems to be missing include clauses to the header under the asm-generic/ directory. This patch works around that by explicitly including both headers under asm-generic. Note that the include of arm/termbits.h had to be removed because it causes yet another conflict, this time due to the redefinition of types termios and ktermios, which also only affects powepc/ppc64el.
|
Wait a while for linux fixes? |
This kind of problem, as it stands right now, is ok fixed on the Debian/Ubuntu package only in case the linux-libc-dev fix doesn't come out soon, but I believe it is good to let you folks know in case someone comes asking about it (and it also helps when folks google for it I guess). =) I will update this when there is a response on the linux-libc-dev bug. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: since the error so far does not seem to be repsnapper's fault, fell free to ignore this pull request.
The headers in linux-libc-dev are different in powerpc/ppc64el compared to other archs, they seems to be missing include clauses to the headers under the asm-generic/ directory.
This patch works around that by explicitly including both headers under asm-generic.
Please note that the include of arm/termbits.h had to be removed because it causes yet another conflict, this time due to the redefinition of types termios and ktermios, which also only affects powerpc/ppc64el.
There is a bug open against Ubuntu's linux-libc-dev about the mismatching headers. Should it be fixed this workaround can be safely ignored.
There are both Debian and Ubuntu bugs open for this workaround.