Update release to handle arm64 and amd64: #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets both arch images push to quay.io Signed-off-by: Jacob Weinstock <[email protected]>
Don't know if i actually need these, but found them here: https://docs.docker.com/build/ci/github-actions/multi-platform/ Signed-off-by: Jacob Weinstock <[email protected]>
Use single buildx command will save time. Use built in GitHub action for logging into Quay.io. This is done with other Tinkerbell repos. Signed-off-by: Jacob Weinstock <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This gets both arch images push to quay.io
Why is this needed
Fixes: #128
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: