Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v14.1.2 #140

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Release v14.1.2 #140

merged 2 commits into from
Feb 1, 2024

Conversation

jscasca
Copy link
Contributor

@jscasca jscasca commented Jan 30, 2024 •
edited
Loading

Related Ticket:

Description of Changes:

  • Placeholder text

Pre-checks:

  • Changelog entry added
  • package.json versions have not been changed (done by Lerna on release)
  • Tests have been added (if applicable)

Before merging:

  • Ensure internal dependencies are on appropriate versions
    • For stable releases, all dependencies must be stable
    • For release candidates, all dependencies must be release candidates or stable

@jscasca jscasca requested a review from a team as a code owner January 30, 2024 11:17
@spocke
Copy link
Member

spocke commented Jan 30, 2024

Should we add you as an admin to this project so that you can publish directly from master.

@jscasca
Copy link
Contributor Author

jscasca commented Jan 30, 2024

That would be nice :)
I'll fix the testing nodes tomorrow so the tests pass

@TheSpyder
Copy link
Member

Systems delivery should be admin on everything. I've added that here.

spocke
spocke approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@spocke spocke left a comment •
edited by jscasca
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Update PR title or publish straight from main

@jscasca jscasca changed the title Feature/tiny 10613 Release v14.1.2 Jan 31, 2024
@jscasca jscasca merged commit a146ee9 into master Feb 1, 2024
5 checks passed
@jscasca jscasca deleted the feature/TINY-10613 branch February 1, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spocke spocke spocke approved these changes

@TheSpyder TheSpyder TheSpyder approved these changes

@hamza0867 hamza0867 Awaiting requested review from hamza0867 hamza0867 is a code owner automatically assigned from tinymce/tinymce-reviewers

@ltrouton ltrouton Awaiting requested review from ltrouton ltrouton is a code owner automatically assigned from tinymce/tinymce-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jscasca @spocke @TheSpyder