-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-2498: Closing a nested modal dialog would lose focus from the editor. #3482
Open
kemister85
wants to merge
1
commit into
feature/7.5/DOC-2498
Choose a base branch
from
feature/7.5/DOC-2498_TINY-11153
base: feature/7.5/DOC-2498
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on the docs as always. I have a few suggestions to make:
Based on my understanding, this issue was not exclusive to inline editors (the title of the JIRA ticket is slightly inaccurate). It still happens in classic mode, but the difference is that inline mode not only loses focus of the dialog, but also hides the UI since it is no longer in focus. So I think we can generalise it to include all editors.
Additionally, I would like to suggest that it's also not necessary to mention the linked issue because it may be more confusing that helpful. Personally I would just focus on the relevant part for the readers which is what the issue was, how it impacted them, and how it's solved.
Feel free to disagree or ask me to edit change my suggestions :)