DOC-2498: Improved color picker aria support. #3490
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemister85
requested review from
abhinavgandham,
soritaheng,
FarzadHayat,
LewisAtTiny and
a team
as code owners
kemister85
requested review from
EkimChau and
ShiridiGandham
and removed request for
a team
kemister85
added
the
upcoming release
ArvinJ-H
reviewed
Oct 24, 2024
| === Screenreader on safari has poor consistency of announcing aria-label | ||
| // #TINY-11291 & #TINY-11430 | ||
|
|
||
| In Safari, when using a screen reader, the focus is incorrectly placed on the content of the input field instead of the input field itself. This behavior results in the screen reader not announcing the content of the `aria-label` associated with the input field. |
There was a problem hiding this comment.
Suggested change
| In Safari, when using a screen reader, the focus is incorrectly placed on the content of the input field instead of the input field itself. This behavior results in the screen reader not announcing the content of the `aria-label` associated with the input field. | |
| In Safari, when using a screen reader on the color picker, the focus is mistakenly placed on the content within the input field rather than the field itself. This causes the screen reader to bypass announcing the aria-label associated with the field. |
ArvinJ-H
reviewed
Oct 24, 2024
|
|
||
| In Safari, when using a screen reader, the focus is incorrectly placed on the content of the input field instead of the input field itself. This behavior results in the screen reader not announcing the content of the `aria-label` associated with the input field. | ||
|
|
||
| As a consequence, users relying on screen readers may not hear the intended description of the input field, leading to potential confusion or accessibility challenges. |
There was a problem hiding this comment.
Suggested change
| As a consequence, users relying on screen readers may not hear the intended description of the input field, leading to potential confusion or accessibility challenges. | |
| As a consequence, users who rely on screen readers may not hear the intended description provided by the aria-label, potentially causing confusion or reducing accessibility. It is currently unknown whether this issue affects other input fields outside the color picker. |
ArvinJ-H
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: DOC-2498
Site: Staging branch
Changes:
Pre-checks:
feature/<version>/,hotfix/<version>/,staging/<version>/, orrelease/<version>/.Review: