Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vgremove: add page #14618

Merged
merged 5 commits into from
Nov 14, 2024
Merged

vgremove: add page #14618

merged 5 commits into from
Nov 14, 2024

Conversation

jackiesogi
Copy link
Contributor

@jackiesogi jackiesogi commented Nov 4, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): LVM version: 2.03.11(2) (2021-01-08); Library version: 1.02.175 (2021-01-08)

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Nov 4, 2024
pages/linux/vgremove.md Outdated Show resolved Hide resolved
Comment on lines 14 to 16
- Set the debug level for detailed logging (level 2):

`vgremove --debug 2 my_volume_group`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 2 the default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood the documentation!!!
-d means level 1 debug info and -dd means level 2... and so on.

@sebastiaanspeck What do you think is better way to demonstrate this example?

Copy link
Member

@sebastiaanspeck sebastiaanspeck Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the correct option, so --debug --debug 😄 . Maybe mention in the description something like repeat --debug to increase the level (upto 6)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to stop you there, I don't want to see --debug --debug --debug --debug --debug --debug --debug

As implied in the 2nd part of your remark.

pages/linux/vgremove.md Outdated Show resolved Hide resolved
Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments above.

Co-authored-by: Sebastiaan Speck <[email protected]>
Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

pages/linux/vgremove.md Outdated Show resolved Hide resolved
pages/linux/vgremove.md Outdated Show resolved Hide resolved
Co-authored-by: Sebastiaan Speck <[email protected]>
@spageektti spageektti merged commit bdb2988 into tldr-pages:main Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants