Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eww: add page #14829

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

eww: add page #14829

wants to merge 2 commits into from
+28 −0

Conversation

rexept
Copy link
Contributor

@rexept rexept commented Nov 14, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):
    0.4.0

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Nov 14, 2024
gutjuri
gutjuri requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have a few comments. apart from this, LGTM :)

pages/linux/eww.md Outdated
@@ -0,0 +1,28 @@
# eww

> Implement your own custom widgets.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That kind of widget is meant here? I assume these are widgets for a graphical desktop environment? Is it for X? Or Wayland? Or both. I think it would be good to make this description a bit longer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to something similar in the GitHub. Lmk if it should be even more explicit.

pages/linux/eww.md Outdated Show resolved Hide resolved
@rexept rexept requested a review from gutjuri November 14, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gutjuri gutjuri gutjuri approved these changes

@cyqsimon cyqsimon Awaiting requested review from cyqsimon cyqsimon is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rexept @gutjuri