add twitter profile id prover #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified notary server: https://github.com/mhchia/notary-server/tree/work-with-extension Changes - websocket connection to notary-server - HTTP request to /session first and get sessionId - Craft it through web_sys - Send HTTP request with `fetch` - Usually it's done with window, but in web worker there is no window - Use WebSocket API to establish wss connection to notary server - Chang notary-server to accept a param `sessionId` - In browser there is no way to add headers, so we couldn't add "X-Session-Id" - Prover config must use the session id returned from the notary server Concerns - Now we have to manually set notary server as trusted since the cert is self-signed. - rootCert couldn't be added when initiating HTTP request due to browser security config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.