-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create symlinks that don't include the version #443
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
I don't quite follow how this makes things easier to manage. Also, |
Hard coding the version in the file path makes using libtock-c from other repos difficult as it's hard to tell where the libraries are installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why we would want this.
This seems to cover a somewhat niche use-case, right? Where you're not using In that case, I'm not sure whether a symlink is the right approach. Isn't there some way to have a file that you include, which simply exports the version and path of those libraries? That avoids modifying the libtock-c tree itself dependent on a build. Something like a symlink would not be stable in environments where we're building with two compiler versions or where we're able to select the libc version per build. |
It's the use case where you use libtock-c as a library. I'm not sure it's really niche as The problem with having dynamic paths is that it's difficult to use libtock-c from other projects, as the location of the libraries and headers changes
Yeah, the symlink doesn't work if you want to change libc versions or doing strange compiler things, but that seems like a niche use case. |
There are Another thing in my head now w.r.t. to symlinks specifically a as a solution: One of the takeaways from TW7 is that there is a growing, serious user base of Windows-native folks for Tock and its ecosystem. We've had Windows as best-effort support for a while, but if there is growing external demand+support, we will probably need to escalate it to a first class citizen. This is relevant here as IIUC symlinks+windows is a no-go for anything robust :/. |
To make libtock-c builds easier to manage let's create symlinks to the libraries that don't include the version information