Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: elixir warning #36

Closed
wants to merge 1 commit into from
Closed

fix: elixir warning #36

wants to merge 1 commit into from

Conversation

yordis
Copy link

@yordis yordis commented Dec 17, 2022 •
edited
Loading

Fixes the following:

warning: Application.get_env/3 is discouraged in the module body, use Application.compile_env/3 instead

@kelvinst
Copy link
Contributor

kelvinst commented Apr 1, 2024

Hi @yordis, thanks for the PR, sorry for the delay in the review. This change does actually break compatibility, as Application.compile_env/3 was introduced in Elixir 1.10, and this lib supports Elixir 1.5 and up.

Anyway, there's another PR doing this exact same change, and we plan on releasing it in a next minor release: #44

@yordis yordis closed this Apr 1, 2024
@yordis yordis deleted the fix-elixir-warning branch April 1, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yordis @kelvinst