feat: Add favro integration #1366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcrammond
suggested changes
Apr 10, 2019
There was a problem hiding this comment.
Thank you for your PR, it's looking good!
I noticed one problem. After starting a timer on a Favro card, if I then hover my mouse over the updated Stop timer button on the card, it changes back to 'Start timer' and I can't stop the timer that way.
It could be related to the selectors, I'm not sure at a glance.
| @@ -637,5 +637,13 @@ export default { | |||
| url: '*://app.vivifyscrum.com/*', | |||
| name: 'VivifyScrum', | |||
| clone: 'true' | |||
| }, | |||
| 'favro.com': { | |||
There was a problem hiding this comment.
Hmm, it probably isn't necessary to have two entries here.
Just the first entry with *://*.favro.com/* as the url should work fine.
There was a problem hiding this comment.
Does that require the . before favro though? Don't want to accidentally match myfavro.com or other domains that end in the same string.
tcrammond
added
the
needs follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please remember the Contributing Guidelines ❤️
🌟 What does this PR do?
Adds the timer integration to cards in the project management tool favro.com
🐛 Recommendations for testing
All changes should be tested across Chrome and Firefox.
📝 Links to relevant issues or information
None