-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Todoist): Project with sections to get project name #2151
base: master
Are you sure you want to change the base?
Conversation
Projects with segments cannot get the project name. As a side note, if the project name is not registered in Toggl and the segment name matches the project name in Toggl, it will be recognized as the project name. This commit is for the list only, and the task detail screen will be fixed separately.
src/content/todoist.js
Outdated
return str; | ||
} | ||
|
||
function isExist(str, arr) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function isExist(str, arr) { | |
function contains(str, arr) { |
Better naming. and should swap arguments too: contains(arr, str)
or use native Array.includes
:
add to PR title the name of what integration you are fixing |
Thanks for the review @glensc.
Thanks for the review @glensc. The title has been changed to correct the areas that were pointed out. |
@tomcat0090 what i had in mind that you include integration name in title, this project (toggl/track-extension) includes many integrations not just integration to "todoist" |
@glensc |
Are there other problems? |
Projects with segments cannot get the project name.
As a side note, if the project name is not registered in Toggl and the segment name matches the project name in Toggl, it will be recognized as the project name.
This commit is for the list only, and the task detail screen will be fixed separately.
Please remember the Contributing Guidelines ❤️
🌟 What does this PR do?
Resolves some of the problems caused by the addition of sections to Todoist.
For the toggle buttons in the following views, the process of obtaining the project name has been corrected.
This will resolve the following Issue.
🐛 Recommendations for testing
All changes should be tested across Chrome and Firefox. -> Done
📝 Links to relevant issues or information
Fixes #2141 #1930