Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(subscriber): test with custom self_wake() function #525

Merged
merged 2 commits into from
Mar 8, 2024

Commits on Feb 16, 2024

  1. test(subscriber): test with custom self_wake() function

    Part of the testing performed in the `console-subscriber` integration
    tests is detecting self wakes. This relied upon the `yield_now()` from
    Tokio.
    
    However, the behavior of this function was changed in
    tokio-rs/tokio#5223 and since Tokio 1.23 the wake doesn't occur in the
    task that `yield_now()` is called from. This breaks the test when using
    a newer version of Tokio.
    
    This change replaces the use of `yield_now()` with a custom
    `self_wake()` function that returns a future which does perform a self
    wake (wakes the task from within itself before returning
    `Poll::Pending`).
    
    The same custom `self_wake()` is also included in the `app` example so
    that it shows self wakes correctly.
    
    Tokio has been updated to 1.28.2 in the lock file (the last with
    compatible MSRV) so that this fix is tested.
    
    Ref #512
    hds committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    c259165 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Configuration menu
    Copy the full SHA
    d855cef View commit details
    Browse the repository at this point in the history