feat: Adjust task and waker panel for long names #527
Conversation
There was a problem hiding this comment.
I haven't had a chance to look to much into the code yet. But from the screenshots, it looks like you're losing lines from the Task panel (I see the scheduled and idle times missing from the bottom).
I'm not sure if you've noticed this, but the task panel will need to have a variable height, whereas right now the height is fixed.
Also, I think that we probably don't need to put the location on its own line (after the label), it should be able to start on the line with the label and then break onto additional lines if it needs to.
I'll come back with a complete review (hopefully tomorrow) once I've had a chance to read the code changes.
|
Ah! Yes, good call. I did not notice that. I’ll need to make some
adjustments
…On Sun, Feb 18, 2024 at 3:56 PM Hayden Stainsby ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I haven't had a chance to look to much into the code yet. But from the
screenshots, it looks like you're losing lines from the Task panel (I see
the scheduled and idle times missing from the bottom).
I'm not sure if you've noticed this, but the task panel will need to have
a variable height, whereas right now the height is fixed.
Also, I think that we probably don't need to put the location on its own
line (after the label), it should be able to start on the line with the
label and then break onto additional lines if it needs to.
I'll come back with a complete review (hopefully tomorrow) once I've had a
chance to read the code changes.
—
Reply to this email directly, view it on GitHub
<#527 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFLL2BYL3QMKR5TYSLC3OQTYUJ2HXAVCNFSM6AAAAABDNPUN36VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOBXGMZTONZUGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
| @@ -9,6 +9,7 @@ use crate::{ | |||
| help::HelpText, | |||
| }, | |||
| }; | |||
| use ratatui::widgets::Wrap; | |||
There was a problem hiding this comment.
style: merge this with the other ratatui imports ok the next line.
| @@ -131,8 +132,8 @@ impl TaskView { | |||
| .direction(layout::Direction::Horizontal) | |||
| .constraints( | |||
| [ | |||
| layout::Constraint::Percentage(50), | |||
| layout::Constraint::Percentage(50), | |||
| layout::Constraint::Percentage(60), | |||
There was a problem hiding this comment.
I think we might want something more dynamic than this. What do you think?
|
Will be coming back to this PR this weekend! Sorry I was out of town last week/over the weekend :D |
|
@devanbenz Friendly ping~ Do you have time to work on it again? Thanks! |
I definitely want to get back to this. I have an interview this week and a talk during the weekend. I have a feeling that afterwards I will likely be able to start contributing to open source more 👍 |
close Friendly ping~ Do you have time to work on it again?
Updated:
