Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): unpin and bump trycmd #572

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

dnaka91
Copy link
Contributor

@dnaka91 dnaka91 commented Jul 10, 2024

The MSRV of 1.64 is long gone and now 1.74. Therefore, the trycmd dev-dependency can be unpinned and bumped to the latest version.

@dnaka91 dnaka91 requested a review from a team as a code owner July 10, 2024 21:48
Copy link
Collaborator

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! 👍

@Rustin170506
Copy link
Collaborator

@dnaka91 Could you please rebase your PR to resolve the conflict? Thank you!

The MSRV of 1.64 is long gone and now 1.74. Therefore, the `trycmd`
dev-dependency can be unpinned and bumped to the latest version.
@dnaka91
Copy link
Contributor Author

dnaka91 commented Jul 15, 2024

Thanks for the pin, I silently waited for the merge but didn't realize there are merge conflicts 😅.

It's rebased now and should be good to go.

Copy link
Collaborator

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@Rustin170506 Rustin170506 merged commit 4543901 into tokio-rs:main Jul 16, 2024
17 checks passed
@dnaka91 dnaka91 deleted the unpin-trycmd branch July 16, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants