Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve error msg when state streaming API is unimplemented #598

Merged

Conversation

Rustin170506
Copy link
Collaborator

close #597

Tested locally:

2024-11-11T14:49:02.786735Z  INFO tokio_console: using target addr target=http://127.0.0.1:6669/
2024-11-11T14:49:02.816255Z ERROR tokio_console::conn: The server at http://127.0.0.1:6669/ does not support state streaming. Please update the console-subscriber to v0.5.0 or later version.
2024-11-11T14:49:02.816351Z  WARN tokio_console::conn: error connecting error=status: Unimplemented, message: "", details: [], metadata: MetadataMap { headers: {"date": "Mon, 11 Nov 2024 14:49:02 GMT", "content-type": "application/grpc", "content-length": "0"} }
2024-11-11T14:49:10.444895Z ERROR tokio_console::conn: The server at http://127.0.0.1:6669/ does not support state streaming. Please update the console-subscriber to v0.5.0 or later version.
2024-11-11T14:49:10.445159Z  WARN tokio_console::conn: error connecting error=status: Unimplemented, message: "", details: [], metadata: MetadataMap { headers: {"date": "Mon, 11 Nov 2024 14:49:10 GMT", "content-type": "application/grpc", "content-length": "0"} }

@Rustin170506 Rustin170506 requested a review from a team as a code owner November 11, 2024 14:49
@Rustin170506
Copy link
Collaborator Author

I think we need to bump the console-subscriber version from 0.4 to 0.5, right? Since it’s a breaking change.

Copy link
Collaborator

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@hds
Copy link
Collaborator

hds commented Nov 11, 2024

@Rustin170506 Yes. we should. I'll make sure we do that in the next release.

@Rustin170506 Rustin170506 changed the title feat: Improve error message when state streaming API is unimplemented feat: improve error msg when state streaming API is unimplemented Nov 11, 2024
@Rustin170506 Rustin170506 merged commit 6ef148a into tokio-rs:main Nov 11, 2024
18 checks passed
@github-actions github-actions bot mentioned this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the error message when using the latest tokio-console with the old console-subscriber
2 participants