Add small string optimisation with compact_str #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DomWilliamsEE
force-pushed
the
master
branch
2 times, most recently
from
8a0dfcd to
555906f
Compare
|
I'd be super interested in having this feature. |
|
There is some issue with one of the CI checks that I couldn't reproduce, I imagine that is the first blocker 😄 |
|
While I do agree this is a handy feature, I currently don't want to accept it. There are a lot of possible variants that people want to add, but this method is not scalable. I have some ideas to make the types used in generated fields more configurable. CompactString could be one of the new types. However, I currently have not the bandwidth to work on that. If you are willing to contribute (time or money), please contact me to figure out the details. Thanks, Casper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature to use
CompactStringin generated code, to reduce allocations with large amounts of short strings.