fix getter/setter generated for optional enum fields should use option

[giangndm]

This PR fixed mismatch between getter/setter generated for optional enum fields and enum value i32 as described in #1027

[caspermeijn]

Why is the name_fallback getter nessesary? You could do .name().unwrap_or_default() to get the same result, right? I think that will result in more idiomatic code.

[caspermeijn]

I would turn this around to simplify the code.

Suggested change

	msg.privacy_level_4_fallback(),
	default_enum_value::PrivacyLevel::PrivacyLevelprivacyLevelFour
	msg.privacy_level_4(),
	Some(default_enum_value::PrivacyLevel::PrivacyLevelprivacyLevelFour)

[caspermeijn]

I would like to see new test cases for an optional protobuf enum field.

[caspermeijn]

I think this should only return an Option<T> for optional protobuf fields. I think it should remain the original code for non-optional fields

[giangndm]

Why is the name_fallback getter nessesary? You could do .name().unwrap_or_default() to get the same result, right? I think that will result in more idiomatic code.

If we use unwrap_or_default, I don't think it can work with some custom default enum like this:

enum PrivacyLevel {
  PRIVACY_LEVEL_ONE = 1;
  PRIVACY_LEVEL_TWO = 2;
  PRIVACY_LEVEL_PRIVACY_LEVEL_THREE = 3;
  PRIVACY_LEVELPRIVACY_LEVEL_FOUR = 4;
}

message Test {
  optional PrivacyLevel privacy_level_1 = 1 [default = PRIVACY_LEVEL_ONE];
  optional PrivacyLevel privacy_level_3 = 2 [default = PRIVACY_LEVEL_PRIVACY_LEVEL_THREE];
  optional PrivacyLevel privacy_level_4 = 3 [default = PRIVACY_LEVELPRIVACY_LEVEL_FOUR];
}

Java implementation use has_ for checking and the field is set with default value in this case. How about think about has_ function?

[caspermeijn]

This PR should only change the generated code for optional enums. The generated code to non-optional enums should be unchanged.

I think optional enums should have two getters: fn #get(&self) -> Option<#ty> and fn #get _or_default(&self) -> #ty. I believe that will cover your usecase and be more correct.