Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: use copy_bidirectional in proxy.rs #5856

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

kiron1
Copy link
Contributor

@kiron1 kiron1 commented Jul 9, 2023

Motivation

The examples/proxy.rs was created before copy_bidirectional #3572 was added to tokio. In #2590 the proxy example was updated to close pending connections. By reusing the copy_bidirectional the example can be simplified.

Solution

Reuse copy_bidirectional in example.

@kiron1 kiron1 force-pushed the example-proxy-copy-bidirectional branch from d364cbb to 5b773c3 Compare July 9, 2023 11:31
@kiron1 kiron1 force-pushed the example-proxy-copy-bidirectional branch from 5b773c3 to 501cb6e Compare July 27, 2023 14:57
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn added the A-examples Area: The examples label Jul 28, 2023
@Darksonn Darksonn merged commit 6aca07b into tokio-rs:master Jul 28, 2023
78 checks passed
@kiron1 kiron1 deleted the example-proxy-copy-bidirectional branch July 28, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-examples Area: The examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants