Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: stabilize task::Id related apis #6891

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

mox692
Copy link
Member

@mox692 mox692 commented Oct 8, 2024

Follow up #6793.

@mox692 mox692 added A-tokio Area: The main tokio crate M-task Module: tokio/task labels Oct 8, 2024
@github-actions github-actions bot added R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR labels Oct 8, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering about these ... but I guess it's probably fine.

Copy link
Contributor

@nurmohammed840 nurmohammed840 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mox692, Did you missed out TaskMeta ?

pub struct TaskMeta<'a> {
/// The opaque ID of the task.
#[cfg(tokio_unstable)]
pub(crate) id: super::task::Id,

Additionally, you also should remove the #[cfg(tokio_unstable)] from TaskMeta and every place where it is used.

@mox692
Copy link
Member Author

mox692 commented Oct 11, 2024

Did you missed out TaskMeta ?

Done.
Note that TaskMeta itself is currently unstable, so we still need the tokio_unstable when we want to access the Id via TaskMeta.

@mox692 mox692 enabled auto-merge (squash) October 11, 2024 10:15
@mox692 mox692 merged commit 5ada511 into tokio-rs:master Oct 11, 2024
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-task Module: tokio/task R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants