feat: tolocars #83

Agustina-Carrion · 2023-02-02T19:53:39Z

added line clamp and checked for some styling of the svg operator icons. I still haven't started with the single view/dynamically fetched logic addition. Just for having a first glimpse of the tolocars index.

pReya

The width of the grid area should be just as wide as the content-width/header on large desktop viewports.

pReya

The tags need to be as wide as their text content (but obviously the tag should never break onto two lines).

pReya

Getting an empty tag here. Not sure why. Maybe the word is just too long?

Agustina-Carrion · 2023-02-03T11:05:05Z

Getting an empty tag here. Not sure why. Maybe the word is just too long?
Nope, there's a bug i need to figure out 😅.. this card should only get one tag... the Boolean(array.length) is not working. I might be skipping a step to actually make it work 🤔

pReya · 2023-02-03T11:09:51Z

Getting an empty tag here. Not sure why. Maybe the word is just too long? Nope, there's a bug i need to figure out 😅.. this card should only get one tag... the Boolean(array.length) is not working. I might be skipping a step to actually make it work 🤔

This is the reason:

            tags={[
              tolocar.frontmatter?.tags?.[0],
              tolocar.frontmatter?.tags?.[1],
            ]}

This will always create an array of length 2. If the input values don't exist it will be ["bla", undefined] – which is still an array of length 2.

So, instead of this, we should do: tags={tolocar.frontmatter?.tags?.slice(0,2)}

Also inside of your card make sure that undefined, null or "" are not rendered at all.

Agustina-Carrion · 2023-02-03T11:42:05Z

Getting an empty tag here. Not sure why. Maybe the word is just too long? Nope, there's a bug i need to figure out 😅.. this card should only get one tag... the Boolean(array.length) is not working. I might be skipping a step to actually make it work 🤔

This is the reason:
            tags={[
              tolocar.frontmatter?.tags?.[0],
              tolocar.frontmatter?.tags?.[1],
            ]}
This will always create an array of length 2. If the input values don't exist it will be ["bla", undefined] – which is still an array of length 2.

So, instead of this, we should do: tags={tolocar.frontmatter?.tags?.slice(0,2)}

Also inside of your card make sure that undefined, null or "" are not rendered at all.

I reckoned that was the issue! Just didn't know how to address it. 🤔 And since it's also in the interventions PR, we might need to change it to prevent bugs in the case of more than 2 tags.

pReya

Can you move the truck image a little bit more to the top? Also the paragraph in this box is supposed to be in the aktiv font.

pReya · 2023-02-03T13:18:11Z

src/components/CarCard.tsx

  date,
-  tagIcon,
+  operatorIcon,


Can we just name this operators? They're not really icons, but logos in my opinion. Also what happens if we have multiple operators (there's one of these examples in the Figma design)? I'd make this an array.

pReya · 2023-02-03T13:21:39Z

src/components/Tag.tsx

+        className || ""
+      }`}
+    >
+      {tagIcon && (title === tagIcon ? renderIcon(tagIcon) : null)}


I don't understand this. This means that the icon will only be rendered when the title and the tagIcon are the same. What's the reasoning here?

I'm struggling with the tagIcon... the idea to attach the icon to the corresponding tag, based on a series of words representing each tagIcon. I didn't try to make it work yet, I left it there to revisit. I might bring it up when we chat briefly.

pReya · 2023-02-03T13:24:59Z

src/interfaces/ITolocars.ts

+  title: string;
+  subtitle?: string;
+  date?: string;
+  footerGrey?: boolean;


In the Layout files, you're hardcoding footerGrey to be true. So we can't change it via frontmatter anymore. I would just remove it from this type.

pReya · 2023-02-03T13:30:34Z

base.css

+  .background-fleet {
+    background-image: url("/truck.svg");
+    background-size: 94.87px 75.38px;
+  }


I think this could be done inline as well with something like bg-[size:94.87px_75.38px] bg-[url('truck.svg')]

tobimori · 2023-02-04T18:31:21Z

Can you move the truck image a little bit more to the top? Also the paragraph in this box is supposed to be in the aktiv font.

Not sure why you said the paragraph should be in the Aktiv font. It's Inter in the design.

Edit: My Figma was buggy and displaying it as Inter. I updated the design accordingly.
Make sure there's secondary text (not bold) with white & 70% opacity, while bold text is 100% opacity.
We don't use our color scale here to match with the background.

Design for reference

github-actions · 2023-02-10T15:16:01Z

✅ Successfully deployed to: https://dev.tolocar.org/feat-tolocars

tobimori · 2023-02-11T08:58:50Z

Please check the behaviour of the cards here:

The image is supposed to be the same height on all trucks, but when content is longer, blocks in the same row that are smaller should expand and fill the height.

Design for reference

These labels also have the wrong letter spacing (it's +0,08em for better reading) and wrong font weight (600 in the design). Please update accordingly.

Responsive behavior of the banner here is still broken (no margin bottom)

Description is meant to be smaller and Inter on mobile

On Tablet, please have smaller margin bottom for the banner (64px or 80px)

github-actions · 2023-02-14T16:22:38Z

✅ Successfully deployed to: https://dev.tolocar.org/feat-tolocars

#TC2 no license plate

github-actions · 2023-05-30T08:55:26Z

✅ Successfully deployed to: https://dev.tolocar.org/feat-tolocars

github-actions · 2023-05-31T14:30:39Z

✅ Successfully deployed to: https://dev.tolocar.org/feat-tolocars

github-actions · 2023-06-03T08:24:43Z

✅ Successfully deployed to: https://dev.tolocar.org/feat-tolocars

feat: tolocars subpage

dbbdbc5

Agustina-Carrion requested a review from pReya February 2, 2023 19:53

feat: tolocars index layout

aedbc29

pReya requested changes Feb 3, 2023

View reviewed changes

feat: tolocars single view layout

d4892ff

pReya requested changes Feb 3, 2023

View reviewed changes

feat: tag icon attached to tag component

789076c

Agustina-Carrion and others added 2 commits February 6, 2023 09:26

fix: styling tolocar header

2ea99b0

Merge branch 'main' into feat/tolocars

0e362c1

pReya had a problem deploying to ionos February 10, 2023 15:07 — with GitHub Actions Failure

fix: build errors

37f4eb8

pReya temporarily deployed to ionos February 10, 2023 15:12 — with GitHub Actions Inactive

pReya temporarily deployed to ionos February 10, 2023 15:13 — with GitHub Actions Inactive

pReya changed the title ~~feat: tolocars subpage~~ feat: tolocars Feb 10, 2023

fix: tolocar banner, car cards grid styling

6ab68d0

Agustina-Carrion temporarily deployed to ionos February 14, 2023 16:17 — with GitHub Actions Inactive

Agustina-Carrion temporarily deployed to ionos February 14, 2023 16:19 — with GitHub Actions Inactive

Delete tolocar02.mdx

7c6e1f0

#TC2 no license plate

Anna2608 temporarily deployed to ionos May 15, 2023 14:51 — with GitHub Actions Inactive

Jacky-Bertlich and others added 12 commits May 30, 2023 10:50

Delete restore-woodenhouse.png

462685a

Add files via upload

ffbe920

Update 07-flashlights.mdx

6a4a7f8

Update 05-cargo-bike-workshop.mdx

b00646e

Update and rename 6_new-year-workshop.mdx to 08-sumy-region.mdx

6df9f42

Update and rename 7_fabrication-for-beginners.mdx to 09-.mdx

fc66331

Rename 09-.mdx to 09-cnc-assembly.mdx

03366bd

Update and rename 8_class.mdx to 10-fabulaser.mdx

961865d

Update 07-flashlights.mdx

04a1e98

Update 06-victoria-chernihiv.mdx

1b5822a

Update 06-victoria-chernihiv.mdx

fde8569

fix: menu links

e8e08f2

pReya temporarily deployed to ionos May 30, 2023 08:50 — with GitHub Actions Inactive

pReya temporarily deployed to ionos May 30, 2023 08:51 — with GitHub Actions Inactive

Jacky-Bertlich and others added 2 commits May 31, 2023 12:53

Create community

df646fe

Merge branch 'main' into feat/tolocars

09567c2

pReya temporarily deployed to ionos May 31, 2023 14:27 — with GitHub Actions Inactive

Update tolocar03.mdx

4ce45c3

Anna2608 temporarily deployed to ionos June 2, 2023 09:20 — with GitHub Actions Inactive

Anna2608 had a problem deploying to ionos June 2, 2023 09:21 — with GitHub Actions Failure

pReya added 2 commits June 3, 2023 09:28

fix: unkeyed map call

e308ef2

Merge branch 'main' into feat/tolocars

bffbce0

pReya temporarily deployed to ionos June 3, 2023 07:37 — with GitHub Actions Inactive

pReya had a problem deploying to ionos June 3, 2023 07:39 — with GitHub Actions Failure

pReya temporarily deployed to ionos June 3, 2023 08:20 — with GitHub Actions Inactive

pReya temporarily deployed to ionos June 3, 2023 08:22 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: tolocars #83

feat: tolocars #83

Agustina-Carrion commented Feb 2, 2023

pReya left a comment

pReya left a comment

pReya left a comment

Agustina-Carrion commented Feb 3, 2023

pReya commented Feb 3, 2023 •

edited

Loading

Agustina-Carrion commented Feb 3, 2023

pReya left a comment

pReya Feb 3, 2023

pReya Feb 3, 2023

Agustina-Carrion Feb 3, 2023

pReya Feb 3, 2023

pReya Feb 3, 2023

tobimori commented Feb 4, 2023 •

edited

Loading

github-actions bot commented Feb 10, 2023

tobimori commented Feb 11, 2023

github-actions bot commented Feb 14, 2023

github-actions bot commented May 30, 2023

github-actions bot commented May 31, 2023

github-actions bot commented Jun 3, 2023

feat: tolocars #83

Are you sure you want to change the base?

feat: tolocars #83

Conversation

Agustina-Carrion commented Feb 2, 2023

pReya left a comment

Choose a reason for hiding this comment

pReya left a comment

Choose a reason for hiding this comment

pReya left a comment

Choose a reason for hiding this comment

Agustina-Carrion commented Feb 3, 2023

pReya commented Feb 3, 2023 • edited Loading

Agustina-Carrion commented Feb 3, 2023

pReya left a comment

Choose a reason for hiding this comment

pReya Feb 3, 2023

Choose a reason for hiding this comment

pReya Feb 3, 2023

Choose a reason for hiding this comment

Agustina-Carrion Feb 3, 2023

Choose a reason for hiding this comment

pReya Feb 3, 2023

Choose a reason for hiding this comment

pReya Feb 3, 2023

Choose a reason for hiding this comment

tobimori commented Feb 4, 2023 • edited Loading

github-actions bot commented Feb 10, 2023

tobimori commented Feb 11, 2023

github-actions bot commented Feb 14, 2023

github-actions bot commented May 30, 2023

github-actions bot commented May 31, 2023

github-actions bot commented Jun 3, 2023

pReya commented Feb 3, 2023 •

edited

Loading

tobimori commented Feb 4, 2023 •

edited

Loading