Numeric arrays #555
Open
Numeric arrays #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: topaz/objects/arrayobject.py topaz/objspace.py
| @@ -44,7 +44,7 @@ def handle_block_args(self, space, bytecode, args_w, block): | |||
| isinstance(args_w[0], W_ArrayObject) and len(bytecode.arg_pos) >= 2): | |||
| w_arg = args_w[0] | |||
| assert isinstance(w_arg, W_ArrayObject) | |||
| args_w = w_arg.items_w | |||
There was a problem hiding this comment.
You can probably dorp the assert here as well.
…umeric_arrays Conflicts: topaz/objects/arrayobject.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to add specialized storage to arrays. This isn't merge ready, but I'm going on vacation until Wednesday and I won't have any Internet access. @alex I realize there is stuff missing here, and there aren't any jit tests, but I'd like to get some discussion about the code going. @merryman may have time to work on this while I'm gone.