Fix count of rooms with deletion priority #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wl-yankabuki
force-pushed
the
fix-count-list-rooms-deletion-priority
branch
from
b953270
to
e2c227a
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 83.47% 83.51% +0.04%
==========================================
Files 84 84
Lines 5399 5400 +1
==========================================
+ Hits 4507 4510 +3
+ Misses 723 722 -1
+ Partials 169 168 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The method ListRoomsWithDeletionPriority must return at least the same number of rooms passed in amount, but now it can return a number greater than that. That makes some rooms to be unable to be replaced when calling the switch version operation