refactor(runtime): make topologySpread configurable #643
+82
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hspedro
force-pushed
the
fix/maxSkew-configurable
branch
from
5f86120
to
2b8b43e
Compare
hspedro
changed the title
hspedro
force-pushed
the
fix/maxSkew-configurable
branch
4 times, most recently
from
3b84d2f
to
5e985aa
Compare
Read the TopologySpreadConstraints config from the YAML config so we can tune based on cluster/game. By default it will be enabled. Using a low value for maxSkew leads to underutilized nodes which impacts in cost.
hspedro
force-pushed
the
fix/maxSkew-configurable
branch
from
5e985aa
to
9adadd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the TopologySpreadConstraints maxSkew, topologyKey, and whenUnsatisfiable from the YAML config so we can tune based on cluster/game. By default, it will be set to 5. Using a low value leads to underutilized nodes which impacts in cost