Unquantize Points during presimplify #22
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifying a topology requires the removal of the transform (if any).
This is done it the presimplify() function.
presimplify() only does that on arcs, not points.
If the topology is quantized again later, points will be quantized twice, yielding invalid values.
With this commit, presimplify() also remove the transform of Point & MultiPoint objects.
The code for this fix is heavily inspired by https://github.com/topojson/topojson-client/blob/71e5bd6428fd8b7a40fa980d2ef7862140851f03/src/quantize.js.
For example, here is a topology corresponding to Washington DC, which has been quantized with
q=1e4
:The location for the label is quantized:
Running
toposimplify -P 0.5 dc.json
was causing the coordinates of the label to be quantized twice: