This repository has been archived by the owner on May 4, 2021. It is now read-only.
Maint 1.1 bug30905 key values count #372
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test that two different instances of state don't overwrite each other. This test don't past in this commit, will pass in the next bugfix. Bugfix v0.7.0, which claimed 100% test coverage on state.
Otherwise, if other instance of state set a key, it's lost by the current instance. Bugfix v0.7.0.
since state use json and json will raise error when it can't decode/encode some datatype.
to be able to serialize/deserailize datetime in the state file.
in RelayList: - Rename consensus_timestamps to recent_consensus - Rename recent_consensus_count to to recent_consensus when there is no counting - Use the timestamps class to manage/count consensuses - Remove method not needed anymore
in RelayList: - Rename recent_measurement_attempt_count to to recent_consensus when there is no counting - Use the timestamps class to manage/count consensuses
in RelayPrioritizer: - Rename recent_priority_list_count to to recent_priority_list when there is no counting - Rename recent_priority_relay_count to to recent_priority_relay when there is no counting - Use the timestamps class to manage/count priority lists/relays
Tests wont' pass with this commit, they'll be fixed in the next commits
using timestamps class. Also add one more result to the tests data and change the test accordingly.
using timestamps class.
monitoring KeyValues.
in ResultDump and incrementing relay's monitoring KeyValues.
Test that the results, state and bandwidth file generated by running the scanner and the generator in the the test network are correct.
Added: - library to check whether the KeyValues make sense - test an example bandwidth file - a command to check an arbitrary bandwidth file Finally, doing something with all these KeyValues! (Quarantine day 7th)
Closes: #30905.
juga0
force-pushed
the
maint-1.1_bug30905_KeyValues_count
branch
from
1926057
to
1aadfd6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.