New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fastapi example #1666

Merged

abondar merged 2 commits into tortoise:develop from waketzheng:refactor-fastapi-example

Jul 16, 2024

Contributor

waketzheng commented Jun 25, 2024

Description

Motivation and Context

Refactor, to reduce duplicated code

How Has This Been Tested?

make ci

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added the changelog accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

waketzheng added 2 commits

June 25, 2024 00:38


          refactor: use schemas and routers to reduce duplicated code in fastap…

256978e

…i example


          Warm tip for module not found

d3232f7

coveralls commented Jun 25, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 9658687196

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 89.095%

Totals
Change from base Build 9646263030:	0.001%
Covered Lines:	5907
Relevant Lines:	6532

💛 - Coveralls

abondar approved these changes

View reviewed changes

abondar merged commit 4c14800 into tortoise:develop

7 checks passed

waketzheng deleted the refactor-fastapi-example branch

August 1, 2024 09:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet