Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mysql UUIDField with binary_compression=True #1687

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

hendelbah
Copy link
Contributor

Fix for binary_compression with mysql UUIDField

Description

Fixed a bug that breaks UUIDField from mysql, probably a misstype

Motivation and Context

Seems that this field doesnt work when binary_compression=True, to_db_value method is broken, so there is a fix

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hendelbah hendelbah changed the title Patch 1 Fix Mysql UUIDField with binary_compression Jul 30, 2024
@hendelbah hendelbah changed the title Fix Mysql UUIDField with binary_compression Fix Mysql UUIDField with binary_compression=True Jul 30, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10166341751

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.158%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/contrib/mysql/fields.py 0 1 0.0%
Totals Coverage Status
Change from base Build 10115140001: 0.0%
Covered Lines: 5939
Relevant Lines: 6550

💛 - Coveralls

@abondar abondar merged commit 686fc95 into tortoise:develop Aug 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants