Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augmentation dots placed too far to the right #7

Closed
dbenjaminmiller opened this issue Jul 7, 2024 · 5 comments
Closed

Augmentation dots placed too far to the right #7

dbenjaminmiller opened this issue Jul 7, 2024 · 5 comments

Comments

@dbenjaminmiller
Copy link
Contributor

dbenjaminmiller commented Jul 7, 2024

Here is a comparison, showing only the difference and all features turned on ''except'' dots, using \ekmSmuflOff #'dot, and then all features turned on (including ekm augmentation dots). The dots are placed too far to the right when esmuflily is used (i.e., they are further from the notehead than they would be natively).

image image

This difference is consistent; the augmentation dots are placed further to the right when esmuflily is enabled.

@dbenjaminmiller
Copy link
Contributor Author

dbenjaminmiller commented Jul 9, 2024

seems that the padding matches native LP when we change the padding in ly:stencil-stack from ext to 0, as follows:

  (let ((ext (ekm-extent dot X)))
    (let cat ((c (max count 0))
              (r (if pad point-stencil empty-stencil)))
      (if (zero? c) r
        (cat (1- c) (ly:stencil-stack r X RIGHT dot 0))))))

@dbenjaminmiller
Copy link
Contributor Author

OK, changing to zero does mess up double dots... so it should only be zero for the first dot.

@tr-igem
Copy link
Owner

tr-igem commented Jul 18, 2024

The wrong placement arises from an additional leading pad with point-stencil. The pad between two or more dots has to be taken from dot extend, at least for markup commands like \ekm-note-by-number and ekm-rest-by-number. So I changed back to Dots.stencil, partly because I think that the pad should be font specific, not Lilypond specific. There is also a SMuFL issue.

@dbenjaminmiller
Copy link
Contributor Author

Interesting, I will have to try out your new version. Does it still produce the same spacing as LP's by default now?

My thinking would be that, if it's possible, we should use the native LilyPond technique for placing symbols (dots or otherwise). Part of this is so the tweaks applied are as close as possible to the native ones.

I don't recall off the top of my head whether or not the dot placement is actually properly tweakable in LP without redefining Dots.stencil altogether, though.

@tr-igem
Copy link
Owner

tr-igem commented Jul 18, 2024

The solution with Dots-stencil affects the pad between two dots, while the spacing between note head and dot is now the same as Lilypond's default.

@tr-igem tr-igem closed this as completed Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants