Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust grace note slash and dot handling #8

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Adjust grace note slash and dot handling #8

merged 4 commits into from
Jul 17, 2024

Conversation

dbenjaminmiller
Copy link
Contributor

I've fixed two issues, although the code might be made a bit more elegant.

  1. Ekmelos has an unusually small grace note slash compared to other SMUFL fonts. See the comparison at Grace note slash the wrong size? ekmelos#4. I've changed the font size of the grace note slash so that it looks proper with other smufl fonts; the glyph in Ekmelos should probably be adjusted accordingly.
  2. Augmentation dots placed too far to the right #7 - I've fixed this issue by changing how we draw augmentation dots. The existing implementation works by replacing the entire Dots stencil (which draws one augmentation dot where there is one, two where there are two, etc.). The spacing of these dots, however, didn't match that which LilyPond gave natively; most notably, the first dot was further away from the notehead than LilyPond would put it. But instead of handling the dot placement, I switched it so that we no longer override Dots.stencil but instead Dots.dot-stencil (the stencil for a single dot). This allows LilyPond to handle the spacing while still using the SMUFL font's dot character.

@tr-igem
Copy link
Owner

tr-igem commented Jul 17, 2024

Yes the size 3 for grace note slashes is wrong. I removed the fontsize command completely (it is unnecessary for 0) and changed also the positioning on the stem according to bravura_metadata.json.

Copy link
Owner

@tr-igem tr-igem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dot-stencil simplifies the dot handling (seems to be a new property in Lilypond 2.24).

@tr-igem tr-igem merged commit 9fb5a90 into tr-igem:main Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants