Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard 1delta #198

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Guard 1delta #198

merged 7 commits into from
Feb 7, 2024

Conversation

hieuh25
Copy link
Contributor

@hieuh25 hieuh25 commented Jan 29, 2024 •
edited
Loading

  • Add whitelistOnedelta to whitelist both 1delta broker proxy and lending pool contract (like Aave)
  • Add new approve delegation functions for token, as vToken needs to be approved delegation
  • Decode and validate 1delta multicall

Part of tradingstrategy-ai/trade-executor#680

@hieuh25 hieuh25 marked this pull request as ready for review February 6, 2024 13:06
miohtama
miohtama requested changes Feb 7, 2024
View reviewed changes
contracts/guard/src/GuardV0.sol Show resolved Hide resolved
contracts/guard/src/GuardV0.sol Show resolved Hide resolved
contracts/guard/src/GuardV0.sol Show resolved Hide resolved
@hieuh25 hieuh25 requested a review from miohtama February 7, 2024 11:21
@miohtama miohtama merged commit 4173e93 into master Feb 7, 2024
1 check passed
@hieuh25 hieuh25 deleted the guard-1delta branch August 23, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miohtama miohtama Awaiting requested review from miohtama

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hieuh25 @miohtama