Draft of indexed errors implementation #467
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Sorry if it's implemented elsewhere, I tried to find but didn't find, that's why I wrote a test case / drafted implementation so we can discuss.
Problem:
When have an API, errors for collections are not indexed, so not sure about what element caused the error. Rails has implemented this behavior on rails/rails#19686
Trying to set this configuration on my app, I wasn't successful, so implemented on Reform
Solution:
Reform::Contract::Result::Errors
if not using indexed errors, keep the usual behavior, else collect all the messages, but organized indexing for collections on the errors hashTODO: @apotonick I know this class variable for configuration is stupid hahaha just wanted a fast
switch for the test case, would it good how? as a feature?