Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined method `[]' for nil:NilClass when using TruffleRuby #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def to_a(*)
# Connector when using Track(:success).
class Track < Struct.new(:color, :adds, :options)
def to_a(*)
search_strategy = options[:wrap_around] ? :WrapAround : :Forward
search_strategy = options&.key?(:wrap_around) ? :WrapAround : :Forward
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the point here to use the safe navigator &. or the key? method? Under which circumstances can options be nil?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the point here to use the safe navigator &. or the key? method?

Both

Under which circumstances can options be nil?

I don't know it happens on application boot :/


return [Linear::Sequence::Search.method(search_strategy), color], adds
end
Expand Down