Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace .must_equal with assert_equal #50

Merged
merged 2 commits into from
May 24, 2024

Conversation

seuros
Copy link
Member

@seuros seuros commented May 23, 2024

There is only 1 type of change in this PR.

@@ -112,6 +112,7 @@ class Update < Trailblazer::Activity::Railway
it do
#:key-title-fail
signal, (ctx, _) = Trailblazer::Activity.(Song::Activity::Update, params: {title: nil}, seq: [])

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding newlines between #: blocks you're changing the way documentation is rendered, so be careful with that! 👶

@apotonick
Copy link
Member

Cool! 💚 Thanks! Could you rebase that patch into the model branch https://github.com/trailblazer/trailblazer-macro/tree/model ? That's the one I was working on (and then forgot to finish it because of our Model::Find() discussion, and so on...). 🌞

@seuros
Copy link
Member Author

seuros commented May 24, 2024

You can edit the target branch in this PR.

@seuros seuros changed the base branch from master to model May 24, 2024 06:49
@apotonick apotonick merged commit cf3ebf9 into trailblazer:model May 24, 2024
7 checks passed
@seuros seuros deleted the fix branch May 24, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants