New CodeQL queries for ML libraries #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This analysis is used to detect false positives in the `LocalMemoryLeak.ql` query.
fegge
changed the title
GrosQuildu
reviewed
Jul 1, 2024
There was a problem hiding this comment.
The queries look to be generic, not ML-focused? So what if we move them from src/ml to src/security?
Then we can keep the queries in the generic security and has ML specific libraries, and in the future can add more libraries (not necessarily ML) for the queries
| where | ||
| leak.reaches(source, var, sink) | ||
| select | ||
| source.getLocation(), toMessage(source, sink, var) |
There was a problem hiding this comment.
I suggest making selects like this:
select
source, "The variable `" + var + "` is allocated on line $@ and may leak on line $@",
source, toLine(source), sink, toLine(sink)first arg doesn't need getLocation (or does it?).
Using $@ makes the line clickable (easier to triage results)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a number of CodeQL queries for the GGML library used by e.g. llama.cpp and whisper.cpp.