Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add size discrepancy analysis, rename filter-ndecoded. #801

Merged
merged 3 commits into from
Jan 11, 2021
Merged

Add size discrepancy analysis, rename filter-ndecoded. #801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1212da8
Add size discrepancy analysis, rename filter-ndecoded.
inventednight Jan 11, 2021
88f1916
Add size discrepancy pass.
inventednight Jan 11, 2021
5f390bc
Fix size discrepancy pass.
inventednight Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ysis/pass/filter-ndecoded/filter-ndecoded → ...filter-ndecoded-same/filter-ndecoded-same
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env ruby
# frozen_string_literal: true

# filter-ndecoded: remove any cohorts where all outputs consumed
# filter-ndecoded-same: remove any cohorts where all outputs consumed
# exactly the same number of input bytes.
#
# NOTE: Observe that "decoded the same number of bytes" is *not* the same
Expand All @@ -11,7 +11,7 @@

require "json"

STDERR.puts "[+] pass: filter-ndecoded"
STDERR.puts "[+] pass: filter-ndecoded-same"

count = 0
STDIN.each_line do |line|
Expand All @@ -26,4 +26,4 @@ STDIN.each_line do |line|
STDOUT.puts result.to_json
end

STDERR.puts "[+] pass: filter-ndecoded done: #{count} filtered"
STDERR.puts "[+] pass: filter-ndecoded-same done: #{count} filtered"
4 changes: 2 additions & 2 deletions src/analysis/pass/filter-ndecoded/spec.yml → ...alysis/pass/filter-ndecoded-same/spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
name: filter-ndecoded
name: filter-ndecoded-same
desc: Filter out any cohorts where all outputs consumed exactly the same number of input bytes
run: filter-ndecoded
run: filter-ndecoded-same
18 changes: 13 additions & 5 deletions src/analysis/passes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
default:
- dedupe
- filter-all-failure
- filter-ndecoded
- filter-ndecoded-same
- minimize-input
- normalize

Expand All @@ -14,6 +14,14 @@ same-size-different-decodings:
- minimize-input
- normalize

# Finds disagreements in size between workers.
size-discrepancies:
- dedupe
- filter-all-failure
- filter-ndecoded-same
- minimize-input
- normalize

# Find inputs that not all workers either succeed or fail on.
status-discrepancies:
- dedupe
Expand All @@ -25,31 +33,31 @@ status-discrepancies:
destroy-capstone:
- dedupe
- filter-all-success
- filter-ndecoded
- filter-ndecoded-same
- filter-destroy-capstone
- minimize-input
- normalize

destroy-bddisasm:
- dedupe
- filter-all-success
- filter-ndecoded
- filter-ndecoded-same
- filter-destroy-bddisasm
- minimize-input
- normalize

xed-overaccept:
- dedupe
- filter-all-success
- filter-ndecoded
- filter-ndecoded-same
- filter-xed-find-overaccept
- minimize-input
- normalize

xed-underaccept:
- dedupe
- filter-all-success
- filter-ndecoded
- filter-ndecoded-same
- filter-bddisasm-salc
- filter-xed-find-underaccept
- minimize-input
Expand Down