Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for streaming inputs such as stdin and sockets as taint source #6511

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Support for streaming inputs such as stdin and sockets as taint source #6511

merged 3 commits into from
Nov 22, 2022

Conversation

hbrodin
Copy link
Collaborator

@hbrodin hbrodin commented Nov 21, 2022

Upon connect/accept a taint source name will be derived from the involved parties. This implementation supports AF_INET sockets.

Enabled instrumentation of a couple of functions such as getchar and others. Tracks read offsets via per source index counters.

Refactor program_trace fixture to use smaller fixtures

Fixes #6501
Closes #6488

@hbrodin
Support for streaming inputs such as stdin and sockets as taint source
4f1915f 
Upon connect/accept a taint source name will be derived from the involved parties.
This implementation supports AF_INET sockets.

Enabled instrumentation of a couple of functions such as getchar and others.
Tracks read offsets via per source index counters.

Refactor program_trace fixture to use smaller fixtures

Fixes #6501
Closes #6488
@hbrodin hbrodin mentioned this pull request Nov 21, 2022
Merged
surovic
surovic suggested changes Nov 21, 2022
View reviewed changes
polytracker/include/taintdag/polytracker.h Show resolved Hide resolved
polytracker/include/taintdag/stream_offset.h Outdated Show resolved Hide resolved
polytracker/src/taint_sources/taint_sources.cpp Outdated Show resolved Hide resolved
polytracker/src/taint_sources/taint_sources.cpp Show resolved Hide resolved
polytracker/src/taint_sources/taint_sources.cpp Show resolved Hide resolved
polytracker/src/taintdag/polytracker.cpp Show resolved Hide resolved
polytracker/src/taintdag/polytracker.cpp Show resolved Hide resolved
tests/test_socket_read.py Show resolved Hide resolved
tests/test_stdin.py Outdated Show resolved Hide resolved
tests/test_stdin.py Show resolved Hide resolved
hbrodin
hbrodin commented Nov 21, 2022
View reviewed changes
Copy link
Collaborator Author

@hbrodin hbrodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your feedback @surovic! Much appreciated. I've addressed all of it and changed some. Please let me know if you think more change is needed now, or if we can do a follow-up.

polytracker/include/taintdag/polytracker.h Show resolved Hide resolved
polytracker/include/taintdag/stream_offset.h Outdated Show resolved Hide resolved
polytracker/src/taint_sources/taint_sources.cpp Outdated Show resolved Hide resolved
polytracker/src/taint_sources/taint_sources.cpp Outdated Show resolved Hide resolved
polytracker/src/taint_sources/taint_sources.cpp Show resolved Hide resolved
unittests/src/taintdag/error_exit_helper.h Outdated Show resolved Hide resolved
tests/test_stdin.py Show resolved Hide resolved
polytracker/src/taint_sources/taint_sources.cpp Show resolved Hide resolved
polytracker/src/taint_sources/taint_sources.cpp Show resolved Hide resolved
polytracker/src/taint_sources/taint_sources.cpp Show resolved Hide resolved
This was referenced Nov 22, 2022
Closed
Open
@surovic surovic merged commit 6f84302 into master Nov 22, 2022
@surovic surovic deleted the feature-sockets-stdin-6488 branch November 22, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surovic surovic surovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hbrodin @surovic