cleaning up the namespace #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work @wcornwell ! I found the reminding dplyr, strings and will remove them now. |
- add explcit namespace to calls of relevant functions
|
Hi @wcornwell I've continued your lead here and also removed stringr and dplyr from the NAMESPACE. I also misunderstood the implications of listing functions as imports here. Removing those packages uncovered a bunch of places where we didn't have an explicit namespace prefix, i..e And we can drop tibble from DESCRIPTION, as you can create a nibble via dplyr |
dfalster
approved these changes
May 2, 2024
|
Oh no, I brok it! |
|
Probably could remove forcats too? |
|
Cool! |
Yes, it is used in one place, though I wonder if that is necessary. Need to check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a mis-understanding of what "imports" in the Description did. Turns out it doesn't Import. That mis-understanding cascaded into some other issues, but I think it's now cleaned up.
We're currently importing two packages: dplyr and stringr, which means we are (somewhere) using functions without the :: .
This is because of the %>% for dplyr . Not sure why for stringr. But I think it's OK.
The importing of individual functions in the namespace was unnecessary.