Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks #234

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Tweaks #234

merged 2 commits into from
Jun 20, 2024

Conversation

slager
Copy link
Contributor

@slager slager commented Jun 18, 2024

Adding this as a PR instead of an issue so that it can get automatically tested with the CI

  • fix an example and re-document
  • make vignette paths more robust, which should fix the vignette building error here.

@slager
Copy link
Contributor Author

slager commented Jun 18, 2024

The failed macos check seems related not to the PR itself, but to connectivity problems in test-connection.R. Maybe it's an intermittent issue, in which case re-running the failed job from the check details page might fix it?

Copy link
Contributor

@wcornwell wcornwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the tweaks @slager ! CI was failing but I think that was an unrelated issue #235

@wcornwell wcornwell merged commit d4f2379 into traitecoevo:develop Jun 20, 2024
5 checks passed
wcornwell added a commit that referenced this pull request Jul 31, 2024
* Bump version number (1.0.0.9000)

[skip ci]

* spelling fixes and removing special Mac install instructions (#229)

* spelling fixes and removing special Mac install instructions

* adding mac back into CI

* Cran preparations (#230)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* cleaning up (#231)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* Removed auto package version in citation

* Updated CRAN comments

* Fixed typo in CITATION

* Resubmitted

---------

Co-authored-by: Fonti Kar <[email protected]>

* fixing badges

* Tweaks (#234)

* fix example

* fix vignette paths

* testing for issue #235

* still working on #235

* one more try to find the edge case

* another edge case?

* reformat code in release file

* another edge case

* reverting previous commit to documentation

* adding check on resources to all functions that need resources

* bumping version number and updating readme

* missed two checking spots

---------

Co-authored-by: Daniel Falster <[email protected]>
Co-authored-by: Fonti Kar <[email protected]>
Co-authored-by: Dave Slager <[email protected]>
wcornwell added a commit that referenced this pull request Aug 13, 2024
* dealing with cran and CI issues (#236)

* Bump version number (1.0.0.9000)

[skip ci]

* spelling fixes and removing special Mac install instructions (#229)

* spelling fixes and removing special Mac install instructions

* adding mac back into CI

* Cran preparations (#230)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* cleaning up (#231)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* Removed auto package version in citation

* Updated CRAN comments

* Fixed typo in CITATION

* Resubmitted

---------

Co-authored-by: Fonti Kar <[email protected]>

* fixing badges

* Tweaks (#234)

* fix example

* fix vignette paths

* testing for issue #235

* still working on #235

* one more try to find the edge case

* another edge case?

* reformat code in release file

* another edge case

* reverting previous commit to documentation

* adding check on resources to all functions that need resources

* bumping version number and updating readme

* missed two checking spots

---------

Co-authored-by: Daniel Falster <[email protected]>
Co-authored-by: Fonti Kar <[email protected]>
Co-authored-by: Dave Slager <[email protected]>

* Update new

* fixing bug in hidden function and re-naming a bit

* adding new genus in family function

* testing?

* namespaces

* testing testing

* forgot how namespaces work

* so many details *sigh*

---------

Co-authored-by: Daniel Falster <[email protected]>
Co-authored-by: Fonti Kar <[email protected]>
Co-authored-by: Dave Slager <[email protected]>
wcornwell added a commit that referenced this pull request Aug 13, 2024
* Bump version number (1.0.0.9000)

[skip ci]

* spelling fixes and removing special Mac install instructions (#229)

* spelling fixes and removing special Mac install instructions

* adding mac back into CI

* Cran preparations (#230)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* cleaning up (#231)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* Removed auto package version in citation

* Updated CRAN comments

* Fixed typo in CITATION

* Resubmitted

---------

Co-authored-by: Fonti Kar <[email protected]>

* fixing badges

* Tweaks (#234)

* fix example

* fix vignette paths

* testing for issue #235

* still working on #235

* one more try to find the edge case

* another edge case?

* reformat code in release file

* another edge case

* reverting previous commit to documentation

* adding check on resources to all functions that need resources

* bumping version number and updating readme

* missed two checking spots

* 238 genus family lookup (#239)

* dealing with cran and CI issues (#236)

* Bump version number (1.0.0.9000)

[skip ci]

* spelling fixes and removing special Mac install instructions (#229)

* spelling fixes and removing special Mac install instructions

* adding mac back into CI

* Cran preparations (#230)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* cleaning up (#231)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* Removed auto package version in citation

* Updated CRAN comments

* Fixed typo in CITATION

* Resubmitted

---------

Co-authored-by: Fonti Kar <[email protected]>

* fixing badges

* Tweaks (#234)

* fix example

* fix vignette paths

* testing for issue #235

* still working on #235

* one more try to find the edge case

* another edge case?

* reformat code in release file

* another edge case

* reverting previous commit to documentation

* adding check on resources to all functions that need resources

* bumping version number and updating readme

* missed two checking spots

---------

Co-authored-by: Daniel Falster <[email protected]>
Co-authored-by: Fonti Kar <[email protected]>
Co-authored-by: Dave Slager <[email protected]>

* Update new

* fixing bug in hidden function and re-naming a bit

* adding new genus in family function

* testing?

* namespaces

* testing testing

* forgot how namespaces work

* so many details *sigh*

---------

Co-authored-by: Daniel Falster <[email protected]>
Co-authored-by: Fonti Kar <[email protected]>
Co-authored-by: Dave Slager <[email protected]>

* bumping version number and updating news

* update readme

* no empty lines in description

---------

Co-authored-by: Daniel Falster <[email protected]>
Co-authored-by: Fonti Kar <[email protected]>
Co-authored-by: Dave Slager <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants