Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chore): Angular 16 update #195

Merged
merged 25 commits into from
Feb 2, 2024

Conversation

tse018
Copy link
Contributor

@tse018 tse018 commented Oct 5, 2023

Updatet to Angular 16, had some issues with running tests and therefor resulted in why I added new ts.config.json file on tests folder, now all the tests is runned on Angular v16.

Added .github/workflows/angular-versions.yaml, so application can be runned on angular version 14, 15 and 16 based on what angular version want to use. Not sure if it is correct way, let me know if it need to be modified / improved.

@pablotransifex
Copy link
Contributor

@tse018 The test/build for node 14 is failing:

The Angular CLI requires a minimum of v16.13.

@tse018 tse018 closed this Oct 11, 2023
@tse018 tse018 reopened this Oct 11, 2023
@tse018
Copy link
Contributor Author

tse018 commented Oct 11, 2023

@tse018 The test/build for node 14 is failing:

The Angular CLI requires a minimum of v16.13.

Angular 16 doesn´t support node v14

@pablotransifex
Copy link
Contributor

pablotransifex commented Oct 11, 2023

@tse018 Node versions updated to 16,18, 20. Could you please rebase to check if tests are working fine?

@tse018
Copy link
Contributor Author

tse018 commented Oct 12, 2023

@tse018 Node versions updated to 16,18, 20. Could you please rebase to check if tests are working fine?

Yes, I have rebased and tested on node 16,18 and 20. Tests works fine. Let me know if you need me to do any changes on this PR

@tse018
Copy link
Contributor Author

tse018 commented Nov 2, 2023

@pablotransifex Let me know when you are ready to merge this, thanks.
Need it for angular 16 project.

@pablotransifex
Copy link
Contributor

@pablotransifex Let me know when you are ready to merge this, thanks. Need it for angular 16 project.

Hello @tse018 I'm trying to check this PR, can you please rebase with master and resolve conflicts? I would like to test locally with the latest transifex/native in place.

Thank you.

@pablotransifex
Copy link
Contributor

pablotransifex commented Jan 18, 2024

@pablotransifex Let me know when you are ready to merge this, thanks. Need it for angular 16 project.

I checked the PR on an Angular 16 project of mine and worked fine, just we need a rebase to merge your PR.

Related to your question: "Added .github/workflows/angular-versions.yaml, so application can be runned on angular version 14, 15 and 16 based on what angular version want to use. Not sure if it is correct way, let me know if it need to be modified / improved." I also don't know what is the correct way, so we can use this way for now.

@tse018

…re/angular-update-v16

# Conflicts:
#	packages/angular/package.json
#	packages/angular/projects/tx-native-angular-sdk/package.json
@tse018
Copy link
Contributor Author

tse018 commented Feb 1, 2024

Have resolved the merge conflicts to using the newest transifex versions

@pablotransifex
Copy link
Contributor

Have resolved the merge conflicts to using the newest transifex versions

Thank you @tse018 now we need to fix the tests, it seems to be dependencies conflicts.

@tse018
Copy link
Contributor Author

tse018 commented Feb 1, 2024

Have resolved the merge conflicts to using the newest transifex versions

Thank you @tse018 now we need to fix the tests, it seems to be dependencies conflicts.

lerna ERR! npm run test stderr:

Error: Cannot find module 'http'

do you know which dependencies its missing from?

@pablotransifex
Copy link
Contributor

@tse018 We will try to find out, in the meantime, maybe it's related to the angular-versions.yaml? We are running tests for node 16, 18 and 20, inside that file there are other node versions, maybe we can test without this file at all or fix those versions inside?

@pablotransifex
Copy link
Contributor

@tse018 We merge a fix for nock #217 so please rebase again, and probably we don't need the angular workflow file, as we are using node version >= 16.

We are thinking on a version for angular 16 only, so maybe better remove the peer dependencies for 14 and 15 and the mentioned angular workflow file.

For older angular versions, users can use other TX Native version that supports them.

@tse018
Copy link
Contributor Author

tse018 commented Feb 1, 2024

@tse018 We merge a fix for nock #217 so please rebase again, and probably we don't need the angular workflow file, as we are using node version >= 16.

We are thinking on a version for angular 16 only, so maybe better remove the peer dependencies for 14 and 15 and the mentioned angular workflow file.

For older angular versions, users can use other TX Native version that supports them.

Understood, will remove and fix it now

Copy link
Contributor

@pablotransifex pablotransifex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @tse018, it was a bit of trouble with this, but in the end all good!

@pablotransifex pablotransifex merged commit 71a9c3d into transifex:master Feb 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants