-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chore): Angular 16 update #195
feat(chore): Angular 16 update #195
Conversation
…cript into feat/chore/angular-update-v16 # Conflicts: # packages/angular/package.json
…e018/transifex-javascript into feat/chore/angular-update-v16
@tse018 The test/build for node 14 is failing:
|
Angular 16 doesn´t support node v14 |
@tse018 Node versions updated to 16,18, 20. Could you please rebase to check if tests are working fine? |
…e018/transifex-javascript into feat/chore/angular-update-v16
Yes, I have rebased and tested on node 16,18 and 20. Tests works fine. Let me know if you need me to do any changes on this PR |
@pablotransifex Let me know when you are ready to merge this, thanks. |
Hello @tse018 I'm trying to check this PR, can you please rebase with master and resolve conflicts? I would like to test locally with the latest transifex/native in place. Thank you. |
I checked the PR on an Angular 16 project of mine and worked fine, just we need a rebase to merge your PR. Related to your question: "Added .github/workflows/angular-versions.yaml, so application can be runned on angular version 14, 15 and 16 based on what angular version want to use. Not sure if it is correct way, let me know if it need to be modified / improved." I also don't know what is the correct way, so we can use this way for now. |
…re/angular-update-v16 # Conflicts: # packages/angular/package.json # packages/angular/projects/tx-native-angular-sdk/package.json
Have resolved the merge conflicts to using the newest transifex versions |
Thank you @tse018 now we need to fix the tests, it seems to be dependencies conflicts. |
lerna ERR! npm run test stderr: Error: Cannot find module 'http' do you know which dependencies its missing from? |
@tse018 We will try to find out, in the meantime, maybe it's related to the angular-versions.yaml? We are running tests for node 16, 18 and 20, inside that file there are other node versions, maybe we can test without this file at all or fix those versions inside? |
@tse018 We merge a fix for We are thinking on a version for angular 16 only, so maybe better remove the peer dependencies for 14 and 15 and the mentioned angular workflow file. For older angular versions, users can use other TX Native version that supports them. |
Understood, will remove and fix it now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @tse018, it was a bit of trouble with this, but in the end all good!
Updatet to Angular 16, had some issues with running tests and therefor resulted in why I added new ts.config.json file on tests folder, now all the tests is runned on Angular v16.
Added .github/workflows/angular-versions.yaml, so application can be runned on angular version 14, 15 and 16 based on what angular version want to use. Not sure if it is correct way, let me know if it need to be modified / improved.