-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: Combined forks / released on my parent #150
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update pom to push release to Maven Central (via OSSRH)
The group Id is domain based and this project can only push to Maven Central under io.jsonwebtoken.*
Correcting the groupid of the fork - io.jsonwebtoken.coveralls
if shared configs, use jars to do so, its far easier and this breaks when trying to clone with tools like github desktop as not exactly correctly. Hardly anyone uses git submodules as they don't work well.
maven can do most of this without need for non maven scripts.
not bothering with samples currently
hazendaz
added a commit
to hazendaz/javaparser
that referenced
this pull request
Nov 25, 2023
Same code lines, see trautonen/coveralls-maven-plugin#150 and trautonen/coveralls-maven-plugin#142. This picks up all including partial clover support (not used here) from the 3 main originals. Main thing is it removes reliance on jakarta bind api removing javax vs jakarta namespace concerns
closing as my fork now the go forwards here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can serve for more discussion. See #142