Imports & Navbar visual changes #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this |
jkarns275
reviewed
Aug 13, 2024
jkarns275
reviewed
Aug 13, 2024
* reworks airsync to fix missing imports --------- Co-authored-by: RIT <[email protected]> Co-authored-by: RIT <[email protected]> Co-authored-by: e911 <[email protected]> Co-authored-by: Aaron Chan <[email protected]> Co-authored-by: Mayur Shinde <[email protected]> Co-authored-by: Joshua Karns <[email protected]>
Unsubscribe links for email preferences + removal of expired unsub tokens.
Add default value for severityColumn state value
Give users with view permission the ability to view uploads (but not modify)
AarC10
requested changes
Sep 3, 2024
Comment on lines
35
to
36
| private static final String baseURL = "https://ngafid.org"; | ||
| //private static final String baseURL = "https://ngafidbeta.rit.edu"; |
There was a problem hiding this comment.
Should this be made into an environment variable?
| String resp = new String(respRaw).replaceAll("tail_number", "tailNumber"); | ||
|
|
||
| Type target = new TypeToken<List<AirSyncAircraft>>(){}.getType(); | ||
| System.out.println(resp); |
Comment on lines
28
to
30
| private static HashMap<Integer, User> users = new HashMap<>(); | ||
| private static HashMap<String, Integer> userIDs = new HashMap<>(); | ||
| private static HashMap<String, HashMap<String, Boolean>> emailTypesUsers = new HashMap<>(); |
There was a problem hiding this comment.
Can the fields just be Maps?
There was a problem hiding this comment.
Probably would have to update a few getters though
There was a problem hiding this comment.
Should probably just update the getters to use the Map interface, but using the concrete HashMap here is fine.
jkarns275
reviewed
Sep 10, 2024
|
honestly LGTM fix conflicts and we send it |
… and uploaders) (#156)
AarC10
approved these changes
Sep 12, 2024
…om/travisdesell/ngafid2.0 into aidan_cu/imports_interface_updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
09/11/24:
"https://ngafid.org"if unsetexport NGAFID_BASE_URL="https://ngafid.org"toinit_env.sh