Roman/file split feature #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eightspokes
commented
Sep 30, 2024
| public static OffsetDateTime convertToOffset(String originalDate, String originalTime, String originalOffset, String newOffset) { | ||
| //System.out.println("original: \t" + originalTime + " " + originalOffset + " new offset: "+ newOffset); | ||
|
|
||
| // create a LocalDateTime using the date time passed as parameter | ||
| LocalDateTime ldt = LocalDateTime.parse(originalDate + " " + originalTime, DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss")); | ||
| LocalDateTime ldt = parseDateTime(originalDate + " " + originalTime); |
There was a problem hiding this comment.
Uses parseDateTime method (utilizes multiple parse formats) instead of doing parsing itself.
eightspokes
commented
Sep 30, 2024
eightspokes
commented
Sep 30, 2024
| @@ -98,10 +98,11 @@ private static void initializeConnectionPool() { | |||
| config.setUsername(dbUser); | |||
| config.setPassword(dbPassword); | |||
There was a problem hiding this comment.
This should match the Database.java from josh/refactor
eightspokes
commented
Sep 30, 2024
| @@ -113,7 +113,6 @@ public static void main(String[] arguments) throws SQLException { | |||
| * non-existant | |||
| * upload. This can cause the upload process to crash. | |||
| * | |||
| * @param connection is the connection to the database | |||
There was a problem hiding this comment.
ProcessUpload from josh/refactor currently throw errors for me, needs revisiting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation contains refactoring changes in CSVFileProcessor file to address an issue where several flights can be placed into a single CSV file.
Development Testing:
G3X file was modified to have a valid header. Also entries were modified to emulate large time gape (greater than 5 minutes)
The date from the flight processor was correctly processed as 2 flights
