-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial PR for simple admin client api and small admin client app #118
base: master
Are you sure you want to change the base?
Conversation
…from KIP 117 and Java code KafkaAdminClient at "https://github.com/apache/kafka/tree/trunk/clients/src/main/java/org/apache/kafka/clients/admin". For a minimal footprint and close to protocol, reuse Jocko's fine Kafka protocol code and client interface code. Move client conn/dial code into a separate package. Other user code only need this client packge and protocol package (few hundreds Ks) to access AdminClient api. Sample of using this admin client api can be found at command line tool "kadmin", which support normal topics create/delete/list/describe,...
… as: kadm topic create -b kafka1:9092 -p 3 -r 2 topic1 topic2 topic3, kadm -b kafka1:9092,kafka2:9092 node list
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
==========================================
+ Coverage 41.4% 41.76% +0.35%
==========================================
Files 84 85 +1
Lines 5936 5572 -364
==========================================
- Hits 2458 2327 -131
+ Misses 3022 2801 -221
+ Partials 456 444 -12
Continue to review full report at Codecov.
|
Good work homie. Here's some layout changes to make:
Look good, similar setup Hashicorp uses. When you've got those changes in place we can work on some style changes. Thanks. |
Thanks for your comments. Here are some more thoughts.
Thanks |
purpose:
kadm init -b kafka1:9092,kafka2:9092
kadm topic list
kadm topic create -p 10 -r 3 topic1 topic2 topic3
kadm topic delete t1 t2 t3
kadm node list
of course, can still target command at specific broker:
kadm group list --brokers kafka1:9092